git, curl, openssl: Refactor $NIX_SSL_CERT_FILE handling #24203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve patching of curl to use NIX_SSL_CERT_FILE as default CA Remove patches from git, as git uses curl and passes its environment variables to curl.
Having curl fall back to openssl's CA means that we need not patch curl to respect NIX_SSL_CERT_FILE. It will work in all the cases. This reverts commit fb4c43d "curl: Use CA bundle in nix default profile by default" If we want to reintroduce that feature, this needs to go inside openssl
|
@layus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edef1c, @domenkozar and @edolstra to be potential reviewers. |
|
cc @shlevy |
|
This should also go to |
|
Nice! |
|
I don't have a darwin box either, sadly. @copumpkin ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The way NIX_SSL_CERT_FILE (and previously SSL_CERT_FILE) support leaks from openssl to git, passing by curl.
This changes shows that
These points correspond to the three commits. The commits should be reviewed separately to make sense.
It is an improvement/rewrite of #24121
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)/cc @shlevy @domenkozar @edolstra @vcunat