Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken: add desktop entry #24543

Merged
merged 1 commit into from
Apr 2, 2017
Merged

gitkraken: add desktop entry #24543

merged 1 commit into from
Apr 2, 2017

Conversation

winniequinn
Copy link
Contributor

Motivation for this change

A desktop entry is always nice for a desktop application like GitKraken! Most other Linux distributions that package GitKraken already have a desktop entry.

Note: The tarball does not contain an icon so switched over to using the dpkg.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@winniequinn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin to be a potential reviewer.

The tarball does not contain an icon so switched over to using the
dpkg.
@winniequinn
Copy link
Contributor Author

I believe @xNWDD may wish to review this as well.

@xNWDD
Copy link
Contributor

xNWDD commented Apr 2, 2017

Reviewed points
  • package built on sandboxed x86_64 Nix
  • icon showing properly on fully clean xfce4
  • executable basic functionality tested on x86_64 Nix
Comments

Because of my tiling addition I didn't even think about the icon xD
But I can see this is a great improvement for most desktop users.

@Mic92 Mic92 merged commit 49aa248 into NixOS:master Apr 2, 2017
@winniequinn winniequinn deleted the gitkraken-desktop-entry branch May 27, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants