Fix consul version being "unknown-unknown". Fixes #24606. #24607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nh2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kamilchm and @pradeepchhetri to be potential reviewers. |
See https://github.com/hashicorp/consul/blob/v0.7.5/scripts/build.sh#L44 for how consul's build script does it.
nh2
force-pushed
the
fix-24606-consul-version-unknown
branch
from
cb30466
to
b03013c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/hashicorp/consul/blob/v0.7.5/scripts/build.sh#L44
for how consul's build script does it.
Done in the same fashion as
nixpkgs/pkgs/applications/networking/cluster/terragrunt/default.nix
Line 21 in 0c928f4
Motivation for this change
#24606
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)