thunderbird: add option to enable calendar #24851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbradar
requested changes
Apr 12, 2017
| @@ -7,7 +7,7 @@ | |||
| , autoconf213, which, m4 | |||
| , writeScript, xidel, common-updater-scripts, coreutils, gnused, gnugrep, curl | |||
| , enableGTK3 ? false, gtk3, wrapGAppsHook | |||
| , debugBuild ? false | |||
| , debugBuild ? false, config | |||
There was a problem hiding this comment.
Please don't use config in a derivation, instead make a new flag argument (enableCalendar or something like that). You can set this flag from config in all-packages.nix. Personally I think that config shouldn't be used for single-package options.
There was a problem hiding this comment.
Okay, sure. Should I do a fixup commit, rebase -i, and force push? Or just add more commits?
There was a problem hiding this comment.
Force-push is usually okay (and we'll need to squash it in the end anyway). Thanks!
|
Yeah enabling it by default sounds fine. And adding a config option may be overkill. |
laMudri
force-pushed
the
thunderbird-calendar
branch
from
e755228
to
f94e0a0
Compare
|
I changed it to be enabled by default, with no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Lightning addon for Thunderbird appears to have been deprecated in favour of the built-in version of the same thing. This change allows the
thunderbirdpackage to be built with calendar support via the optionthunderbird.enableCalendar.I currently have it disabled by default. Possibly it should be enabled by default, given that official builds come with the calendar. I don't know whether there are any best practices for this sort of thing.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)