Update my pkgs #25206
Merged
Update my pkgs #25206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthiasbeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @jgeerds and @vcunat to be potential reviewers. |
Mic92
reviewed
Apr 25, 2017
| @@ -13191,8 +13191,6 @@ with pkgs; | |||
| inherit (gnome2) libgnomeui GConf; | |||
| }; | |||
|
|
|||
| cortex = callPackage ../applications/misc/cortex { }; | |||
|
|
|||
There was a problem hiding this comment.
a comment in the commit, why this was removed, would be nice.
There was a problem hiding this comment.
Done and pushed.
I removed cortex it is rather unmaintained. The last update (as of writing) was 8 months ago, there was no release ever. For a better alternative, have a look at `rtv`.
matthiasbeyer
force-pushed
the
update-my-pkgs
branch
from
bdf4f3f
to
cca20a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates for some of my pkgs.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)