Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono: init at 5.0 #25235

Merged
merged 3 commits into from
Jul 5, 2017
Merged

mono: init at 5.0 #25235

merged 3 commits into from
Jul 5, 2017

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Apr 26, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pSub pSub added the 8.has: package (new) This PR adds a new package label May 3, 2017
0xABAB
0xABAB reviewed Jul 1, 2017
View reviewed changes
pkgs/development/compilers/mono/generic-cmake.nix Outdated
];

configurePhase = ''
substituteInPlace ./autogen.sh --replace "/usr/bin/env sh" "/bin/sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #183

0xABAB
0xABAB approved these changes Jul 1, 2017
View reviewed changes
Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you fix the reference to /bin/sh.

@kuznero
Copy link
Member Author

kuznero commented Jul 1, 2017

Now also using ${stdenv.shell} instead of hardcoded /bin/sh

@7c6f434c 7c6f434c merged commit 16f02e8 into NixOS:master Jul 5, 2017
@kuznero kuznero deleted the mono5x branch July 6, 2017 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xABAB 0xABAB 0xABAB approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kuznero @bjornfor @0xABAB @pSub @7c6f434c