Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
1.8.1 fixes some issues with MacOS Sierra (golang/go#19734)
as part of this, a fix for golang/go#19772 is bringing to light a bug in the way we invoke
dsymutil
, which happens to be a stub in darwincctools
(during the build), and generally/usr/bin/dsymutil
at runtime.I'm not entirely sure of the correctness of the fix though, so feedback highly welcome !
I ran
nox-review
on both MacOS and NixOS, and some compilations failed (likegcsfuse
andqsyncthingtray
on NixOS,consul
,heroku
andcadvisor
on MacOS) but as far as I can tell are already failing in master.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)