Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: 1.8 -> 1.8.1 #25568

Merged
merged 2 commits into from
May 9, 2017
Merged

go: 1.8 -> 1.8.1 #25568

merged 2 commits into from
May 9, 2017

Conversation

sigma
Copy link
Contributor

@sigma sigma commented May 6, 2017

Motivation for this change

1.8.1 fixes some issues with MacOS Sierra (golang/go#19734)
as part of this, a fix for golang/go#19772 is bringing to light a bug in the way we invoke dsymutil, which happens to be a stub in darwin cctools (during the build), and generally /usr/bin/dsymutil at runtime.
I'm not entirely sure of the correctness of the fix though, so feedback highly welcome !

I ran nox-review on both MacOS and NixOS, and some compilations failed (like gcsfuse and qsyncthingtray on NixOS, consul, heroku and cadvisor on MacOS) but as far as I can tell are already failing in master.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@sigma, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ixmatus, @Mic92 and @LnL7 to be potential reviewers.

@Mic92 Mic92 requested a review from copumpkin May 7, 2017 06:47
@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label May 7, 2017
@LnL7
Copy link
Member

LnL7 commented May 7, 2017

@sigma Have you tried to build this with clang-4, this might be unnecessary now. Otherwise we can probably bump it to 3.9.

@sigma
Copy link
Contributor Author

sigma commented May 7, 2017

@LnL7 yep, clang 4 works too

@LnL7 LnL7 merged commit 0d6d47e into NixOS:master May 9, 2017
@sigma sigma deleted the pr/go-1.8.1 branch May 25, 2017 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants