Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{lib}mediainfo{-gui}: 0.7.91 -> 0.7.95 #25688

Merged
merged 1 commit into from
May 11, 2017
Merged

{lib}mediainfo{-gui}: 0.7.91 -> 0.7.95 #25688

merged 1 commit into from
May 11, 2017

Conversation

k0ral
Copy link
Contributor

@k0ral k0ral commented May 10, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@k0ral, thanks for your PR! By analyzing the history of the files in this pull request, we identified @devhell to be a potential reviewer.

@devhell
Copy link
Contributor

devhell commented May 11, 2017

+1 thank you very much :)

1 similar comment
@devhell
Copy link
Contributor

devhell commented May 11, 2017

+1 thank you very much :)

@Mic92 Mic92 merged commit b22c629 into NixOS:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k0ral @mention-bot @devhell @Mic92