ovmf: split firmware image files #25896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joachifm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @aszlig to be potential reviewers. |
|
I've successfully built |
OVMF{,CODE,VARS}.fd are now available in a dedicated fd output, greatly
reducing the closure in the common case where only those files are used (a
few MBs versus several hundred MBs for the full OVMF).
Note: it's unclear why `dontPatchELF` is now necessary for the build to
pass (on my end, at any rate) but it doesn't make much sense to run this
fixup anyway,
Note: my reading of xen's INSTALL suggests that --with-system-ovmf should
point directly to the OVMF binary. As such, the previous invocation was
incorrect (it pointed to the root of the OVMF tree). In any case, I have
only built xen with `--with-system-ovmf`, I have not tested it.
Fixes NixOS#25854
Closes NixOS#25855
|
Fair warning, I consider this "done" & intend to merge this if nobody objects. |
|
Xen part LGTM.
|
|
@oxij thank you. I'll go ahead with this, then. |
joachifm
referenced
this pull request
in NixOS/nixpkgs-channels
Jul 14, 2017
(cherry picked from commit df5d588)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OVMF closure is huge, while we often only need
OVMF{,_CODE,VARS}.fd.See #25854
Not sure about why
dontPatchELFnow seems to be necessary for the build to pass, nor have I tested with Xen, so this is still WIP.