Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jackaudio: 1.9.10 -> 1.9.11-RC1 #26626

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jun 16, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@cillianderoiste
Copy link
Member

We discussed this on IRC. There hasn't been a jack2 release in 3 years, and this version is considered stable except that they need to fix Windows and OsX builds before cutting a final release: http://jack-audio.10948.n7.nabble.com/Jack-Devel-JACK2-1-9-11-RC1-is-now-tagged-td19490.html

If that doesn't happen, and this version is adopted by mainstream audio distros i.e. it becomes a de-facto release, then I'd be happy to include it in nixpkgs, but personally, I would like to wait a bit for things to settle down.

@magnetophon
Copy link
Member Author

magnetophon commented Jun 16, 2017

@cillianderoiste The current maintainer of jack is also the creator of KXStudio, and has confirmed it's safe:
jack-git has been part of KXStudio for several months.

@joachifm joachifm added the 8.has: package (update) This PR updates a package to a newer version label Jun 16, 2017
@cillianderoiste
Copy link
Member

@magnetophon Ah, if KXStudio has been using it for months, then I think it's fine. Can you delete the jack-gcc5.patch file too please? Do you think we need to keep jack2Unstable at all? I see it's only used in libsoundio, so I guess that can use 1.9.11-RC1 instead?

@magnetophon
Copy link
Member Author

@cillianderoiste OK, done.

@cillianderoiste cillianderoiste merged commit 7d747e1 into NixOS:master Jun 19, 2017
@cillianderoiste
Copy link
Member

Excellent, thanks @magnetophon!

@magnetophon
Copy link
Member Author

@cillianderoiste The pleasure is all mine. For way too long I had a jack override to unstable, so I had to compile a lot of stuff on each upgrade.
Soon, no more!

@magnetophon magnetophon deleted the jackaudio branch June 19, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants