Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pygraphviz: fix build #26752

Merged
merged 1 commit into from
Jun 23, 2017
Merged

pythonPackages.pygraphviz: fix build #26752

merged 1 commit into from
Jun 23, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 21, 2017

Motivation for this change

See issue #26738

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Loaded the library and run an example
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

FRidh
FRidh reviewed Jun 22, 2017
View reviewed changes
pkgs/development/python-modules/pygraphviz/default.nix Outdated
buildInputs = [ doctest-ignore-unicode mock nose ];
propagatedBuildInputs = [ graphviz pkgconfig ];

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always include a comment motivating why

@FRidh FRidh merged commit a807c96 into NixOS:master Jun 23, 2017
@FRidh
Copy link
Member

FRidh commented Jun 23, 2017

thanks

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 23, 2017

@FRidh Can you cherry-pick into 17.03 so we can close #26738?

@FRidh
Copy link
Member

FRidh commented Jun 23, 2017

2fee075

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 23, 2017

Thank you.

@rnhmjoj rnhmjoj deleted the graphviz branch September 12, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnhmjoj @mention-bot @FRidh