qbs: init at 1.8 #27015
qbs: init at 1.8 #27015
Conversation
expipiplus1
force-pushed
the
qbs
branch
2 times, most recently
from
274de3c
to
fc3fb91
Compare
| qtscript | ||
| ]; | ||
|
|
||
| installFlags = [ "INSTALL_ROOT=$(out)" ]; |
There was a problem hiding this comment.
Looks good to me. Do you mean the inner or outer parentheses?
There was a problem hiding this comment.
I meant those in $(out). Shouldn't that be ${out}? (Given that you see nothing wrong, I am probably just unaware of something.)
There was a problem hiding this comment.
This style is used in a few other places in nixpkgs
pkgs/applications/editors/focuswriter/default.nix
pkgs/applications/audio/iannix/default.nix
pkgs/applications/misc/cool-retro-term/default.nix
for example
There was a problem hiding this comment.
@0xABAB ${out} would refer to the nix value out which doesn't exist. Here $(out) expands the out environment variable, present at build time.
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Qbs is a tool that helps simplify the build process for developing projects across multiple platforms"; |
There was a problem hiding this comment.
description should not contain the name of the package. See https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes.
| qtscript | ||
| ]; | ||
|
|
||
| installFlags = [ "INSTALL_ROOT=$(out)" ]; |
There was a problem hiding this comment.
Looks good to me. Do you mean the inner or outer parentheses?
|
Thanks! |
No description provided.