nixos/nginx: make redirect status code configurable #271506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misterio77
force-pushed
the
nginx-redirect-status-code
branch
from
fbde713
to
f2b5067
Compare
Misterio77
force-pushed
the
nginx-redirect-status-code
branch
from
f2b5067
to
7230f20
Compare
Misterio77
force-pushed
the
nginx-redirect-status-code
branch
from
7230f20
to
c2879c5
Compare
AndersonTorres
approved these changes
Dec 4, 2023
Misterio77
force-pushed
the
nginx-redirect-status-code
branch
from
c2879c5
to
9dd5d41
Compare
pbsds
reviewed
Dec 4, 2023
RaitoBezarius
requested changes
Dec 9, 2023
Misterio77
force-pushed
the
nginx-redirect-status-code
branch
from
9dd5d41
to
9f629ae
Compare
|
Thanks! Added myself as a maintainer on the test |
RaitoBezarius
approved these changes
Dec 10, 2023
|
Ideally, if you can add a note in the release notes about this new option, that'd be great, then we can go for the merge. |
Misterio77
force-pushed
the
nginx-redirect-status-code
branch
from
9f629ae
to
e6d036d
Compare
Add an option to configure which code globalRedirect and forceSSL use. It previously was always 301 with no easy way to override.
Misterio77
force-pushed
the
nginx-redirect-status-code
branch
from
e6d036d
to
a3c60d2
Compare
|
Thanks, @RaitoBezarius! Added an entry to the changelog. |
pbsds
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently, both globalRedirect and forceSSL always use 301, with no easy way to change it through services.nginx options. This PR adds an option to configure it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.