Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8812au driver fixes #28203

Merged
merged 2 commits into from
Aug 12, 2017
Merged

rtl8812au driver fixes #28203

merged 2 commits into from
Aug 12, 2017

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

This PR has two commits, one to fix a regression caused by a 5d693c8, which cleaned up the
substitute() function in stdenv and caused a line in this derivation to fail.
The other commit includes patches to fix compilation against 4.12.

I've tested this against both 4.9 and 4.12 and it works with fine with my AC1200 wireless USB adapter.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The commit 5d693c8 cleaned up the
substitute() function in stdenv and caused this line to
fail.
This includes the patches from the pull requests NixOS#42, NixOS#43, and NixOS#46
submitted to Grawp/rtl8812au_rtl8821au
@mention-bot
Copy link

@danielfullmer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @yochai and @globin to be potential reviewers.

@Mic92 Mic92 merged commit 5839cef into NixOS:master Aug 12, 2017
@danielfullmer danielfullmer deleted the rtl8812-fix branch August 12, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants