-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
petsc: init at 3.7.6 #28368
petsc: init at 3.7.6 #28368
Conversation
Can you take a look at $out/bin. There are scripts with broken shebangs like ' /bin/csh' and windows binaries inside and unrelated files like |
@Mic92, thanks for the help and feedback. For now, I opted to just remove the offending files you mentioned. I hope this is a satisfying solution for now. I will probably need to return to this later in order to add support for MPI. |
For the next iteration on this package it also might be interesting to make use of |
@jamtrott : thanks for this package; I'm currently looking at adding MPI support and have a few questions:
|
@bzizou, my pleasure.
I look forward to seeing your pull request! |
@bzizou: I've learned that the conda-forge is always a good place to look for some ideas on how to best build various stuff: https://github.com/conda-forge/petsc-feedstock/blob/master/recipe/build.sh#L7
|
Feel free to have a look at: https://github.com/knedlsepp/nixpkgs/tree/extend-petsc |
My WIP is here: https://github.com/Gricad/nix-ciment-channel/tree/master/ciment/petsc Update: now working (with openblasCompat), updated link above |
@bzizou: Got petsc compiling and passing the checkPhase. This was probably due to using
|
Yes, tests are passing with openblasCompat!! Ok, continuing :-) |
For fftw, I think that we first need to add openmpi support into it... |
@bzizou: I actually already did that: https://github.com/knedlsepp/nixpkgs/commits/extend-petsc |
@knedlsepp : should'nt you push it upstream by making a PR? |
Definitely! I was thinking we should do that in one chunk with a "petsc: Add missing features"-PR once we are satisfied with it. |
Well, yes. Do you want to make this PR? My WIP is now very similar to your's and my time is over for this two days on this topic. I think that you can simply add the |
Motivation for this change
Add the PETSc library, so that it may later be used by, e.g., the FEniCS computing platform (https://fenicsproject.org) for solving partial differential equations.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)