Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eigen: fix configuration file for pkg-config #28508

Merged
merged 1 commit into from
Aug 23, 2017
Merged

eigen: fix configuration file for pkg-config #28508

merged 1 commit into from
Aug 23, 2017

Conversation

juliendehos
Copy link
Contributor

Motivation for this change

Fix pkg-config file for eigen3_3 (same as eigen) -> the command:

$ nix-shell -p eigen3_3 pkgconfig --pure --run "pkg-config --cflags eigen3"

returns something like:

-I/nix/store/2f366hh65bb46jpzk5m9wvmbfm8d7fia-eigen-3.3.3//nix/store/2f366hh65bb46jpzk5m9wvmbfm8d7fia-eigen-3.3.3/include/eigen3

but it should return something like:

-I/nix/store/8c33w272zvxwaacyharsrmzp2m7827f1-eigen-3.3.3/include/eigen3
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@juliendehos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c and @vcunat to be potential reviewers.

@joachifm joachifm merged commit 3709a86 into NixOS:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants