Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ugm: init at 1.4.0 #287467

Merged
merged 2 commits into from
Apr 11, 2024
Merged

ugm: init at 1.4.0 #287467

merged 2 commits into from
Apr 11, 2024

Conversation

oosquare
Copy link
Contributor

@oosquare oosquare commented Feb 9, 2024

Description of changes

ugm is a terminal-based UNIX user and group browser. Homepage: https://github.com/ariasmn/ugm.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@oosquare
Copy link
Contributor Author

oosquare commented Feb 9, 2024

According to the readme, this program can't work well on Darwin, although it can be compiled normally. Should I add badPlatforms = [ platforms.darwin ]; in meta?

pkgs/by-name/ug/ugm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ug/ugm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ug/ugm/package.nix Show resolved Hide resolved
pkgs/by-name/ug/ugm/package.nix Outdated Show resolved Hide resolved
@oosquare
Copy link
Contributor Author

oosquare commented Feb 9, 2024

Updated. @Aleksanaa

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix run github:oo-infty/nixpkgs/init-ugm#ugm

image

Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think there is a policy about whether a package is qualified to be added into Nixpkgs now. However, I think adding this package is of little value because it is an inactive one-man project and its functionality is not very useful.

@Aleksanaa
Copy link
Member

However, I think adding this package is of little value because it is an inactive one-man project and its functionality is not very useful.

It is valuable as long as someone needs it and someone wants to maintain it.

@jian-lin
Copy link
Contributor

jian-lin commented Feb 9, 2024

My concern is more about the quality of the ugm project.

pkgs/by-name/ug/ugm/package.nix Outdated Show resolved Hide resolved
@AndersonTorres
Copy link
Member

The diffs are not good. Fix this.

@oosquare oosquare marked this pull request as draft February 10, 2024 02:00
@oosquare oosquare marked this pull request as ready for review February 10, 2024 05:16
@wegank
Copy link
Member

wegank commented Apr 11, 2024

@ofborg build ugm ugm.passthru.tests

@wegank wegank merged commit 6271b14 into NixOS:master Apr 11, 2024
25 checks passed
@oosquare oosquare deleted the init-ugm branch April 11, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants