Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mattermost: fix create role #28874

Merged
merged 1 commit into from
Sep 13, 2017
Merged

nixos/mattermost: fix create role #28874

merged 1 commit into from
Sep 13, 2017

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Sep 1, 2017

postgresql create role no longer supports NOCREATEUSER option. See
https://www.postgresql.org/docs/9.6/static/release-9-6.html for
details.

cc @fpletz

postgresql create role no longer supports NOCREATEUSER option. See
https://www.postgresql.org/docs/9.6/static/release-9-6.html for
details.
@ryantm ryantm mentioned this pull request Sep 6, 2017
1 task
@joachifm joachifm merged commit c9200f8 into NixOS:master Sep 13, 2017
@joachifm joachifm added this to the 17.09 milestone Sep 17, 2017
@joachifm
Copy link
Contributor

@fpletz I suppose this should be included in the release, as well?

@fpletz
Copy link
Member

fpletz commented Sep 17, 2017

Yeah! We're going through all the commits on master anyway and this is already on staging-17.09: cc7c4bb. I hope we don't need that staging branch again after the currently running full rebuild.

@joachifm
Copy link
Contributor

@fpletz d'oh I didn't realize staging for 17.09 was a thing ...

@fpletz
Copy link
Member

fpletz commented Sep 17, 2017

The important things are only the fixes for systemd and ncurses. It is a full rebuild as we also cherry-picked #27598 which only applies to Darwin but includes a change to the cc-wrapper. We're trying to maintain 17.09 as a stable channel for Darwin.

So the chance of breakage is near zero but the full rebuild is annoying. :)

@joachifm
Copy link
Contributor

I meant d'oh in that I've been picking stuff to the release without realizing that stuff may already be staged for merging :)

@ryantm ryantm deleted the mattermost branch November 18, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants