Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyring: 8.4.1 -> 10.4.0 #29069

Merged
merged 2 commits into from
Sep 7, 2017
Merged

keyring: 8.4.1 -> 10.4.0 #29069

merged 2 commits into from
Sep 7, 2017

Conversation

teto
Copy link
Member

@teto teto commented Sep 7, 2017

Motivation for this change

Bumped the library thinking it would fix an offlineimap bug but it didn't. Rather than losing the bump I send it here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner September 7, 2017 08:18
@Mic92 Mic92 merged commit 7dad10d into NixOS:master Sep 7, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 7, 2017

Thanks!

@teto teto deleted the keyring branch September 7, 2017 08:58
@teto
Copy link
Member Author

teto commented Sep 7, 2017

thanks for merging !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teto @Mic92