warp-terminal: added passthru update script

[imadnyc]

Description of changes

Finally got around to adding a passthru update script. Here, I manually updated the macOS hash because to my understanding update-source-version expects a platform+architecture, but doesn't accept a general platform, which warp does with it's .dmg (again, to my understanding, I don't have a mac). I also wanted to add myself as a maintainer of this, but I already have that commit in #291443, and didn't want to duplicate the commit. If this is ready to be merged before that, though, I'll remove that one and add it here.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/does-update-source-version-have-a-generic-system-flag/40679/1

[ghost]

change looks good. minor comments inline.
do you want to add yourself to the maintainers?

[imadnyc]

Yeah, I'd like to be a maintainer if my other PRS aren't going to be merged before this. I'll update the other ones if this gets merged.

[ghost]

Yeah, I'd like to be a maintainer if my other PRS aren't going to be merged before this. I'll update the other ones if this gets merged.

add the maintainer commit to this PR as this PR is close to getting merged.

you need to fix your other commit message though. the body is not adding anything useful to someone who will be looking at the commit logs sometime in the future.

look at the output from git log for some examples.

[imadnyc]

I've added myself to the maintainer list and removed my commit body - I was squashing instead of amending and forgot to remove the commit messages getting added to the body.

[ghost]

there are some somewhat strict rules about commit messages. the commits need to be:
maintainers: add imadnyc
warp-terminal: added passthru update script

the maintainers needs to come first, otherwise if someone is performing a bisect the eval will break if they land on the warp-terminal change because you are missing from the maintainers file. you'll need to do something like git rebase -i HEAD~2 reorder the commits and rewrite the maintainer message.

[imadnyc]

I'm gonna pretend it was because I didn't drink coffee today and nothing else. I think it should be good for real this time

[ghost]

LGTM. validated curl -s https://api.github.com/users/imadnyc|jq '{name,github:.login,githubId:.id}' matches github info in maintainers

[ghost]

haven't seen an update posted yet. this might need to be nix-hash --to-sri as nix hash is experimental and can generate an error if the magic config settings are not set.

[ghost]

or not -- i see nix hash in some other update.sh. pkgs/tools/video/recyclarr/update.sh and looks like it had an auto-update. #267039

and the update script has not run yet on warp-terminal. https://r.ryantm.com/log/warp-terminal/