pythonPackages.textacy: init at 0.4.1 #29334
Conversation
|
@rvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jgillich, @carlsverre and @FRidh to be potential reviewers. |
| @@ -0,0 +1,29 @@ | |||
| { stdenv | |||
| , pkgs | |||
| @@ -0,0 +1,31 @@ | |||
| { stdenv | |||
| , pkgs | |||
| @@ -0,0 +1,128 @@ | |||
| { stdenv | |||
| , pkgs | |||
| , nose | ||
| }: | ||
| let | ||
| ijson = buildPythonPackage rec { |
There was a problem hiding this comment.
why are these packages not called from python-packages.nix?
pkgs/top-level/python-packages.nix
Outdated
| @@ -14313,6 +14313,20 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| cachetools = buildPythonPackage rec { | |||
pkgs/top-level/python-packages.nix
Outdated
| @@ -24150,11 +24164,11 @@ EOF | |||
|
|
|||
|
|
|||
| unidecode = buildPythonPackage rec { | |||
| name = "Unidecode-0.04.18"; | |||
| name = "Unidecode-0.04.21"; | |||
|
|
|||
| src = pkgs.fetchurl { | |||
There was a problem hiding this comment.
fetchPypi and preferable separate file
| @@ -27308,6 +27322,12 @@ EOF | |||
|
|
|||
| spacy = callPackage ../development/python-modules/spacy { }; | |||
|
|
|||
| spacy_models = callPackage ../development/python-modules/spacy/models.nix { }; | |||
There was a problem hiding this comment.
Might be nicer to add this to passthru.models of spacy. No need though.
There was a problem hiding this comment.
I think I will pass on this because the data model packages have dependencies on spacy.
|
Thanks for the review @FRidh. I have addressed your comments in new commits which can be autosquashed. |
|
@rvl please do the squashing yourself; commit per package. |
Higher version is a requirement of textacy.
Textacy requires a later version. v2.0.0 introduced breaking changes, so keep two versions for other packages.
This module is a requirement of textacy.
Model Version es_core_web_md 1.0.0 fr_depvec_web_lg 1.0.0 en_core_web_md 1.2.1 en_depent_web_md 1.2.1 en_core_web_sm 1.2.0 de_core_news_md 1.0.0 en_vectors_glove_md 1.0.0
|
@FRidh OK, have pushed the squashed commits. |
|
Thanks @FRidh :-) |
|
Very sorry @FRidh, it appears I forgot to retest the spacy_models packages. Would you be able to apply this patch? rvl@b7e602a |
Motivation for this change
Natural language processing with Python under Nix.
Datasets
The language data models can't be downloaded in the way described by the spaCy docs because their download script is a wrapper around
pip install. The data files total a couple GB and need enough/tmpspace to assemble. I'm assuming that because the derivations exist under an attrset, they won't be automatically built by Hydra (good).Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"-- didn't use nox but have tested build ofmopidy-gmusic, but not the "oslo" packages because they are already marked broken../result/bin/)/cc @sdll