Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nicotine-plus: migrate to gtk4 #294593

Merged
merged 2 commits into from
Mar 12, 2024
Merged

nicotine-plus: migrate to gtk4 #294593

merged 2 commits into from
Mar 12, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Mar 9, 2024

Description of changes

#287866 (comment)

Also moved to by-name, so that the merge bot now works.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank
Copy link
Member Author

wegank commented Mar 12, 2024

Result of nixpkgs-review pr 294593 run on aarch64-linux 1

2 packages built:
  • nicotine-plus
  • nicotine-plus.dist

@wegank wegank merged commit 13da11d into NixOS:master Mar 12, 2024
39 checks passed
@wegank wegank deleted the nicotine-plus-gtk4 branch March 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant