Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internetarchive: 0.8.3 -> 1.7.2 #29484

Merged
merged 3 commits into from
Sep 17, 2017
Merged

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 16, 2017

Motivation for this change

fixes build failures.

Tests are disabled because they fail when trying to Popen the ia binary that's installed. If I disable tests, I can manually run the ia binary without any issues. Happy to enable tests if someone can point me in the right direction to make the binary exist when the tests run.

Adds backports.csv and schema modules from pypi as dependencies.

related to #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 43b6116 into NixOS:master Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants