Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pafy: 0.5.2 -> 0.5.3.1 #29588

Merged
merged 3 commits into from
Sep 21, 2017
Merged

pythonPackages.pafy: 0.5.2 -> 0.5.3.1 #29588

merged 3 commits into from
Sep 21, 2017

Conversation

thufschmitt
Copy link
Member

Motivation for this change

Fix mpsyt which was no longer working

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Sep 20, 2017
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -25835,11 +25835,11 @@ EOF

pafy = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this expression to python-modules/pafy/default.nix and use fetchPypi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Mic92 Mic92 merged commit e76c2c1 into NixOS:master Sep 21, 2017
Mic92 pushed a commit that referenced this pull request Sep 21, 2017
@Mic92
pythonPackages.pafy: 0.5.2 -> 0.5.3.1 (#29588)
6052d2b 
* pythonPackages.pafy: 0.5.2 -> 0.5.3.1

* pythonPackages.pafy: move to its own file

* pythonPackages.pafy: fetchurl -> fetchPypi

(cherry picked from commit e76c2c1)
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017

also in 17.09: 6052d2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thufschmitt @Mic92 @FRidh