Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pytensor, python3Packages.pymc Add ferrine to maintainers for pytensor and pymc #296716

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

ferrine
Copy link
Contributor

@ferrine ferrine commented Mar 17, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Add Max Kochurov to Maintainers List, a core developer of PyMC
Add Max Kochurov (Core PyMC Developer) to maintainers list
Add Max Kochurov (Core PyMC Developer) to maintainers list
@ferrine ferrine changed the title python311Packages.pytensor, python311Packages.pymc Add ferrine to maintainers for pytensor and pymc python3Packages.pytensor, python3Packages.pymc Add ferrine to maintainers for pytensor and pymc Mar 18, 2024
@ferrine
Copy link
Contributor Author

ferrine commented Mar 28, 2024

Hi, @nidabdella can you please have a look?

@wegank wegank merged commit 72a3d65 into NixOS:master Apr 5, 2024
21 checks passed
@ferrine ferrine deleted the add-ferrine-to-maintainers branch April 8, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants