Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

little_boxes: init at 1.10.0 #296973

Merged
merged 2 commits into from
Apr 5, 2024
Merged

little_boxes: init at 1.10.0 #296973

merged 2 commits into from
Apr 5, 2024

Conversation

giodamelio
Copy link
Contributor

Description of changes

Add the little_boxes cli at version 1.10.0

This is my first time contributing to nixpkgs, please let me know if there is any changes to the package to make it more idiomatic!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

AndersonTorres
AndersonTorres suggested changes Mar 18, 2024
View reviewed changes
pkgs/by-name/li/little_boxes/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/little_boxes/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/little_boxes/package.nix Show resolved Hide resolved
@giodamelio
Copy link
Contributor Author

Is it normal for the passthru.tests on aarch64-darwin to take this long? It's been over a day since the job was queued.

@giodamelio
Copy link
Contributor Author

Maybe this will work.

@ofborg build little_boxes.passthru.tests

@AndersonTorres
Copy link
Member

Is it normal for the passthru.tests on aarch64-darwin to take this long? It's been over a day since the job was queued.

Yes, it is. I don't know precisely why, but the bootstrap of Nixpkgs on the ARM Darwin machines is very slow.

@giodamelio
Copy link
Contributor Author

Looks like we are good to go.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1552

Aleksanaa
Aleksanaa approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

=> echo aaa | ./result/bin/little_boxes
┏━━━━━┓
┃ aaa ┃
┗━━━━━┛

@Aleksanaa Aleksanaa merged commit 430c29b into NixOS:master Apr 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@giodamelio @AndersonTorres @nixos-discourse @Aleksanaa @wegank @NixOSInfra