Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdig: remove broken patchelf call #29931

Merged
merged 1 commit into from
Sep 29, 2017
Merged

sysdig: remove broken patchelf call #29931

merged 1 commit into from
Sep 29, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 29, 2017

Motivation for this change

patchelf broke sysdig/csysdig binaries. I don't why this was added in the first place. 17.09 might be also affected by this breakage.

UPDATE 17.09 is also affected.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

patchelf broke sysdig/csysdig binaries
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 29, 2017
@Mic92
Copy link
Member Author

Mic92 commented Sep 29, 2017

Ok. I think the problem was here, that new libraries where added. I suspect that in earlier versions the builds system was broken and was was by using patchelf.

@Mic92 Mic92 merged commit 63f56e0 into NixOS:master Sep 29, 2017
@Mic92 Mic92 deleted the sysdig branch September 6, 2018 08:47
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants