qbittorrent: 3.3.15 -> 3.3.16, drop patch, enable parallel build #29971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
force-pushed
the
qbittorrent/3.3.16
branch
2 times, most recently
from
704b7b2
to
d89c925
Compare
orivej
reviewed
Sep 30, 2017
| patches = [ ./fix-lrelease.patch ]; | ||
|
|
||
| # https://github.com/qbittorrent/qBittorrent/issues/1992 | ||
| enableParallelBuilding = false; |
There was a problem hiding this comment.
Parallel building is disabled by default, you have to set it to true to enable.
orivej
force-pushed
the
qbittorrent/3.3.16
branch
from
d89c925
to
bc334e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Patch doesn't apply anymore, upstream has changed the patched file heavily, and now patching isn't required to build the program:
https://github.com/qbittorrent/qBittorrent/blob/master/qm_gen.pri#L7-L13
I've built it in parallel with
-j8, so hopefully the same will apply to-j50builds.See: qbittorrent/qBittorrent#1992
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)