git: Properly wrap Git commands that are implemented in Perl.

[mboes]

Some Git commands are implemented as Perl scripts. Some of these
scripts use Perl modules from CPAN. Without wrapping these programs to
set GITPERLLIB, these programs would not be fully functional because
some Perl libraries are found to be missing at runtime.

git-svn was one such program. It was already wrapped properly,
provided svnSupport = true. Similarly for git-send-mail. But this
wrapping did not extend to other commands.

Fixes #29996

[zimbatm]

LGTM

[zimbatm]

14296 packages will be rebuilt

[orivej]

I don't like that this manually lists perl programs instead of wrapping all programs (except git-svn and git-send-email) with a perl shebang.

[zimbatm]

oops I've missed your comment @orivej. Can you expand your objection a bit? I don't understand the issue that you are seeing.

[zimbatm]

pushed as 07ca7b6 in the release-17.09 branch

[orivej]

The issue is that if git adds new perl programs or rewrites old perl programs in another language, the wrapper will have to be updated. I propose that we iterate over git-exec/ and wrap all programs with a perl shebang, this way we will not have to maintain the wrapper.

This was not necessary to do in this PR and I don't mind that you've merged it.

[zimbatm]

Ok. I agree that we might potentially have more maintenance down the road with the current approach but I am not sure if wrapping all the libexec programs is the right approach either. Another option would be to wrap the git binary itself and let it propagate the environment variables to the sub-programs.

Anyways, right now it's fixed, it will come back at the next upgrade of if it becomes too annoying to maintain.

[mboes]

I propose that we iterate over git-exec/ and wrap all programs with a perl shebang

I think this is a good idea. Note that this PR didn't introduce a problem that wasn't already there: the existing code is already singling out some commands to be wrapped - it's just that a few had been forgotten over time!