nixos: clean up wifi firmware & default kernel modules #30172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All available options were just enabling hardware.enableRedistributableFirmware. There were nix files without modules which weren't referenced anywhere.
* the keyboard modules in all-hardware.nix are already defaults of boot.initrd.availableKernelModules * ide modules, hid_lenovo_tpkbd and scsi_wait_scan have been removed because they're not available anymore * i8042 was a duplicate (see few lines abowe)
bjornfor
approved these changes
Oct 7, 2017
dezgeg
reviewed
Oct 7, 2017
| @@ -211,21 +206,11 @@ in | |||
| "xhci_hcd" | |||
| "xhci_pci" | |||
| "usbhid" | |||
| "hid_generic" "hid_lenovo" | |||
| "hid_apple" "hid_logitech_dj" "hid_lenovo_tpkbd" "hid_roccat" | |||
| "hid_generic" "hid_lenovo" "hid_apple" "hid_roccat" | |||
|
|
|||
| # Misc. keyboard stuff. | |||
| "pcips2" "atkbd" "i8042" | |||
There was a problem hiding this comment.
Maybe i8042 could be removed from here assuming the kernel problem has been fixed? Not sure if that's worth it though.
There was a problem hiding this comment.
I've investigated a bit but wasn't able to find any information. It's safer to keep it around for now IMHO.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.