pup: rename attr, go-pup -> pup, clean up, 20160425-e76307d -> 0.4.0, add meta #32872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
changed the title
lukateras
force-pushed
the
20171219.232832/pup
branch
from
e2b4713
to
6b3f049
Compare
orivej
reviewed
Dec 20, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -4136,6 +4134,8 @@ with pkgs; | |||
| libXNVCtrl = linuxPackages.nvidia_x11.settings.libXNVCtrl; | |||
| }; | |||
|
|
|||
| pup = callPackage ../development/tools/pup { }; | |||
There was a problem hiding this comment.
Please move it to the development/tools (### DEVELOPMENT / TOOLS) section.
| homepage = "https://${goPackagePath}"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ yegortimoshenko ]; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
FYI buildGoPackage automatically sets platforms, but setting it explicitly is also fine. (I checked again to see if it automatically sets homepage, but it does not. You may as well make it do in pkgs/development/go-modules/generic/default.nix.)
lukateras
force-pushed
the
20171219.232832/pup
branch
from
6b3f049
to
40702af
Compare
|
All fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pup is a very popular tool (4084 stars on GitHub) and in my opinion deserves a three-letter attrname and an update to a stable version :-)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)