Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.nutils: unbreak by adding missing deps; python312Packages.nutils-poly: init #331845

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Aug 2, 2024

Description of changes

CC: @Scriptkiddi
Saw that this package was failing on hydra, so I tried to fix it.

This PR fixes the nutils python package's derivation by adding required dependencies.

The nutils-poly package is also a new dependency, but was not yet packaged in nixpkgs.
I added this package in a separate commit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium
Copy link
Member

Result of nixpkgs-review pr 331845 at 41222b9f run on aarch64-darwin 1

4 packages failed to build:

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Aug 3, 2024

I pushed a change, hopefully it fixes the error on darwin

@natsukium
Copy link
Member

Result of nixpkgs-review pr 331845 at d43931f run on aarch64-darwin 1

4 packages built successfully:
  • python311Packages.nutils
  • python311Packages.nutils-poly
  • python312Packages.nutils
  • python312Packages.nutils-poly

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit c38e7e6 into NixOS:master Aug 10, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants