melpaPackages: match version of magit-popup to magit

[benley]

Related to magit/magit#3286

Motivation for this change

I was getting weird errors trying to use magit features that involved magit-popup

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[benley]

oops, I see the missing semicolon. Fix coming in a sec.

[lukateras]

@GrahamcOfBorg eval

[ttuegel]

A word of warning: this only works as long as the user doesn't install magit-popup explicitly; if they do that, they will get the incompatible version. Actually, Emacs will try to install both versions simultaneously. That's impossible, so I'm not sure what will happen.

[lukateras]

I've accepted this because melpaPackages already has similar overrides in a few other places:

nixpkgs/pkgs/applications/editors/emacs-modes/melpa-packages.nix

Line 46 in f0f290e

inherit (self.melpaPackages) powerline;

nixpkgs/pkgs/applications/editors/emacs-modes/melpa-packages.nix

Line 69 in f0f290e

inherit (self.melpaPackages) easy-kill;

nixpkgs/pkgs/applications/editors/emacs-modes/melpa-packages.nix

Line 82 in f0f290e

inherit (self.melpaPackages) ess ctable popup;

[ttuegel]

I've accepted this because melpaPackages already has similar overrides in a few other places:

You were right to; this is the best we can do for now!

[benley]

A word of warning: this only works as long as the user doesn't install magit-popup explicitly; if they do that, they will get the incompatible version. Actually, Emacs will try to install both versions simultaneously. That's impossible, so I'm not sure what will happen.

I've experimented with that scenario, and it appears that the older incompatible version wins out. It effectively just negates this workaround, I think.