Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 28.0.0.126 -> 28.0.0.137 #33645

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 9, 2018

Motivation for this change

The release notes are not updated yet.

https://helpx.adobe.com/flash-player/release-note/fp_28_air_28_release_notes.html
https://helpx.adobe.com/security.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Fits CONTRIBUTING.md.

  • Built packages

    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"
  • Played a video with Firefox and Chromium.

  • Checked the version with Firefox, Chromium, flashplayer-standalone, and flashplayer-standalone-debugger (x86_64) http://www.adobe.com/software/flash/about/


@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 9, 2018
@joachifm joachifm merged commit b88ddaa into NixOS:master Jan 10, 2018
@pierrebeaucamp
Copy link

Well, those urls are dead again. May I ask how those checksums are generated so I can submit a PR myself? Just curl | sha256sum ?

@taku0
Copy link
Contributor Author

taku0 commented Feb 9, 2018

@pierrebeaucamp already merged at #34732.

FYI, the hashes are computed with nix-hash --base32 --type sha256.

@pierrebeaucamp
Copy link

Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants