-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.progressbar2: init at 3.12.0 #33920
Conversation
975c192
to
99e035a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you disable tests?
setup.py
seems to download missing requirements:
Download error on https://pypi.python.org/simple/pytest-runner/: [Errno -2] Name or service not known -- Some packages may not be found!
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
But no luck even if we use pytestrunner
from nixpkgs, since pytest-runner>=2.8
is required. We will need to update it beforhand.
Maybe you didn't see the download errors if you don't have enabled sandboxing.
}: | ||
|
||
buildPythonPackage (rec { | ||
name = "${pname}-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for name
. Will be derived from pname
and version
.
Also, you can leave out (
and )
.
sha256 = "16r21cpjvv0spf4mymgpy7hx6977iy11k44n2w9kipwg4lhwh02k"; | ||
}; | ||
|
||
buildInputs = [ pytest ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest
belongs into checkInputs
.
Last commit should have dealt with all issues. I had a little trouble getting tests to run, and currently need to pull from GitHub, not PyPI (notified upstream, commented in expression). |
@FRidh Shouldn't have been merged. I still get
We need to add |
Right, I missed that. It seems |
Motivation for this change
New python package, simple to use progress bar
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)