Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.multidict: 3.3.2 -> 4.0.0 #33931

Merged
merged 1 commit into from
Jan 21, 2018
Merged

pythonPackages.multidict: 3.3.2 -> 4.0.0 #33931

merged 1 commit into from
Jan 21, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

nox-review shows that httpbin cannot be built. See #33615.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @FRidh @primeos

@dotlambda dotlambda requested a review from FRidh as a code owner January 16, 2018 11:39
@dotlambda
Copy link
Member Author

ping @FRidh

@primeos primeos merged commit 58e7823 into NixOS:master Jan 21, 2018
@primeos
Copy link
Member

primeos commented Jan 21, 2018

LGTM, thanks 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotlambda @primeos @GrahamcOfBorg