Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samba: 4.6.11 -> 4.7.4 #34085

Merged
merged 3 commits into from
Jan 24, 2018
Merged

samba: 4.6.11 -> 4.7.4 #34085

merged 3 commits into from
Jan 24, 2018

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change
Things done

updated samba and then made it compile again

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 20, 2018

@GrahamcOfBorg build samba

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘acl-2.2.52’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/development/libraries/acl/default.nix:29 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7w507yadfwhgjlp1g7bm9701zplnljf0-samba-4.7.4-dev/lib
patching script interpreter paths in /nix/store/7w507yadfwhgjlp1g7bm9701zplnljf0-samba-4.7.4-dev
checking for references to /build in /nix/store/7w507yadfwhgjlp1g7bm9701zplnljf0-samba-4.7.4-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/fi43mcv5cbwarzqvh9fad9ixpn2r4w37-samba-4.7.4-man
gzipping man pages under /nix/store/fi43mcv5cbwarzqvh9fad9ixpn2r4w37-samba-4.7.4-man/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/fi43mcv5cbwarzqvh9fad9ixpn2r4w37-samba-4.7.4-man
checking for references to /build in /nix/store/fi43mcv5cbwarzqvh9fad9ixpn2r4w37-samba-4.7.4-man...
/nix/store/sjx583fzsxg7kq71yrr4psbr1fsgapsx-samba-4.7.4

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w7k2m2j563f4xnc29rx6w0jihi4l7jqg-samba-4.7.4-dev/lib 
patching script interpreter paths in /nix/store/w7k2m2j563f4xnc29rx6w0jihi4l7jqg-samba-4.7.4-dev
checking for references to /tmp/nix-build-samba-4.7.4.drv-0 in /nix/store/w7k2m2j563f4xnc29rx6w0jihi4l7jqg-samba-4.7.4-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/kgf5k7p17h2n8awp2ix320ca0ixwj1kc-samba-4.7.4-man
gzipping man pages under /nix/store/kgf5k7p17h2n8awp2ix320ca0ixwj1kc-samba-4.7.4-man/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/kgf5k7p17h2n8awp2ix320ca0ixwj1kc-samba-4.7.4-man
checking for references to /tmp/nix-build-samba-4.7.4.drv-0 in /nix/store/kgf5k7p17h2n8awp2ix320ca0ixwj1kc-samba-4.7.4-man...
/nix/store/kdl486szsvxwkl9wq63amj35xab5y8rp-samba-4.7.4

@ikervagyok
Copy link
Contributor Author

@grahamc: do you have a Mac to test 'acl' on it? Did it even work before? I would test it, if I had a Mac, but I don't.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 24, 2018

Did it even work before?

No, it didn't. acl has been a build input of samba since the package was first added to nixpkgs.

ACL are a POSIX feature and darwin is only "mostly POSIX". However looking into the build system of acl darwin is at least handled so we could try to enable it (currently its platforms are restricted to Linux) and see if it builds. Ideally it could be set to platforms.unix.

@ikervagyok
Copy link
Contributor Author

Yeah, but I didn't find an 'it works officially' commit, so I didn't push the issue of changing it's status to 'platforms.unix'

@grahamc grahamc merged commit 2a2793f into NixOS:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants