Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yabar-unstable: 2018-01-02 -> 2018-01-18 #34138

Merged
merged 1 commit into from
Jan 23, 2018
Merged

yabar-unstable: 2018-01-02 -> 2018-01-18 #34138

merged 1 commit into from
Jan 23, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 22, 2018

Motivation for this change

The following changes landed in master:

  • Reset colors unconditionally (2f1ee69d4c75e210265dca732ff6c2ddd7f440f2)
  • Document NixOS support (993f1b5a7bc2a41a353a104cff0763860c053c92)
  • ya_int_song: improve configuration of playerctl properties (1f776cd5f1f4e89e6ebca3ca09feb7e09f79e79e)
  • 1f776cd5f1f4e89e6ebca3ca09feb7e09f79e79e (3a3a361ae0d5f04ad93ca4e9829b3298c83db129)

(NOTE: I recompiled yabar locally and tested the result with my own config and everything continued to work)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
yabar-unstable: 2018-01-02 -> 2018-01-18
0b5a36f 
The following changes landed in master:

- Reset colors unconditionally (2f1ee69d4c75e210265dca732ff6c2ddd7f440f2)
- Document NixOS support (993f1b5a7bc2a41a353a104cff0763860c053c92)
- ya_int_song: improve configuration of playerctl properties (1f776cd5f1f4e89e6ebca3ca09feb7e09f79e79e)
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 22, 2018
@adisbladis adisbladis merged commit 9130212 into NixOS:master Jan 23, 2018
@Ma27 Ma27 deleted the update-yabar branch January 23, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ma27 @adisbladis @GrahamcOfBorg