duktape: init at 2.2.0 #34285
Merged
duktape: init at 2.2.0 #34285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Jan 26, 2018
|
|
||
| meta = { | ||
| version = "2.2.0"; | ||
| description = "Duktape is an embeddable Javascript engine, with a focus on portability and compact footprint"; |
There was a problem hiding this comment.
No duktape in description. See https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes.
There was a problem hiding this comment.
Right, sorry. i just copypasted that without thinking
| ''; | ||
| enableParallelBuilding = true; | ||
|
|
||
| meta = { |
dotlambda
approved these changes
Jan 26, 2018
|
@dotlambda it's there because I wanted to try updateWalker, but I never found any info about it (do you have any pointers about it?). Moving it now. |
|
Ah I see. I never heard of |
|
@GrahamcOfBorg build duktape |
There was a problem hiding this comment.
Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘duktape-2.2.0’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/interpreters/duktape/default.nix:24 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Success on x86_64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0
shrinking /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0/bin/duk
shrinking /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0/lib/libduktape.so.202.20200
shrinking /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0/lib/libduktaped.so.202.20200
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0/lib /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0/bin
patching script interpreter paths in /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0
checking for references to /tmp/nix-build-duktape-2.2.0.drv-0 in /nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0...
/nix/store/hxw18j0mywzkp5rah2v112m5r2n6kq13-duktape-2.2.0
There was a problem hiding this comment.
Success on aarch64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0
shrinking /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0/lib/libduktaped.so.202.20200
shrinking /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0/lib/libduktape.so.202.20200
shrinking /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0/bin/duk
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0/lib /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0/bin
patching script interpreter paths in /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0
checking for references to /build in /nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0...
/nix/store/bd31f56w5r3b2zldg7wkfzxb7c3p3m62-duktape-2.2.0
|
Should I enable building on darwin or is this mergeable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The duktape js interpreter
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)