nixos/dovecot: no " in mailbox.name

[dotlambda]

Motivation for this change

See #34629.

We might want to backport to 17.09.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

/cc @phdoerfler @FRidh

[andir]

Sound like a reasonable thing to do. Might be worth following up with dovecot upstream anyway?

[dotlambda]

Do you mean updating the 17.09 package? I think we shouldn't update from 2.2.33.2 to 2.3.0.
2.2.33.2 is the newest release in the 2.2 branch so we should be fine.

[andir]

I did backport this to 17.09 and then realized that we can not use strMatching there yet. Do you have another solution? E.g. build another type

The issue is that the regex code isn't present on 17.09 per default.

[andir]

I meant asking the upstream project how one would properly escape an "

[dotlambda]

Well the other solution would be to use stringToCharacters and check for " using elem. But that's probably horribly inefficient.

I asked them about escaping on IRC.

[FRidh]

I did backport the "faulty" commit from in #34629, so it either needs to be fixed in 17.09 or reverted.

[dotlambda]

It is not faulty. Mailbox names with quotes inside do lead to doveconf complaining about errors in the configuration file after and before that commit.
This PR would just make it impossible to specify a mailbox qith quotes in the name. So essentially, right now Dovecot is complaining whereas if this gets merged nixos-rebuild will complain about it.