Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CImg and WxCam: New Packages #3519

Closed
wants to merge 1 commit into from
Closed

CImg and WxCam: New Packages #3519

wants to merge 1 commit into from

Conversation

AndersonTorres
Copy link
Member

In this commit, I'm including two softwares:

  • CImg: A small, simple image toolkit library
  • WxCam: a small, simple, wxGTK-based webcam application

@AndersonTorres
Copy link
Member Author

Well, sorry my complete lack of understanding on Git...
I started building wxCam, but only after the 1st try I found it needed CImg library. So, I included an expression to install Cimg too.

I think the cleaner way to do it was just to create a new branch for CImg, but when I do it, a branch hides the files contained in the other. So, I decided to build both on the same branch. It is not so bat at all - CImg is very simple indeed, just a huge CImg.h file (and some extra documentation); and WxCam is not so hard to understand too...

@AndersonTorres AndersonTorres changed the title CImg and WxCam - New Packages CImg and WxCam: New Packages Aug 20, 2014
meta = {
description = "A small, open source, C++ toolkit for image processing";
homepage = http://cimg.sourceforge.net/;
license = cecill-c;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the license is not inside `with stdenv.lib`` here, am I wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the license is in stdenv.lib! Line 80 of lib/licenses.nix.
Also, many thanks, I will fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • buildInputs = with stdenv.lib;
  • [ unzip ];
  • builder = ./builder.sh;
  • meta = {
  • description = "A small, open source, C++ toolkit for image processing";
  • homepage = http://cimg.sourceforge.net/;
  • license = cecill-c;

Yes, the license is in stdenv.lib! Line 80 of lib/licenses.nix.

But this line seems to be out of scope where stdenv.lib.licenses is
visible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget the stdenv.lib path :/

In this commit, I'm including two new softwares
* CImg: A small, simple image toolkit library
* WxCam: a small, simple, wxGTK-based webcam application
install -m 644 CImg.h $out/include/cimg
cp -dr --no-preserve=ownership html/* $out/share/doc/cimg/html/
cp -dr --no-preserve=ownership examples/* $out/share/cimg/examples/
cp -dr --no-preserve=ownership plugins/* $out/share/cimg/plugins/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you only need to set dontBuild=true in the expression and override only installPhase

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I like the builder.sh approach when the building is completely ad-hoc. It is considered "old-fashioned" but is more modular...

7c6f434c pushed a commit to 7c6f434c/nixpkgs that referenced this pull request Sep 4, 2014
In this commit, I'm including two new softwares
* CImg: A small, simple image toolkit library
* WxCam: a small, simple, wxGTK-based webcam application
@7c6f434c
Copy link
Member

7c6f434c commented Sep 4, 2014

Merged manually.

@Fuuzetsu
Copy link
Member

Fuuzetsu commented Sep 5, 2014

Yes, merged, closing.

@Fuuzetsu Fuuzetsu closed this Sep 5, 2014
@AndersonTorres AndersonTorres deleted the wxcam branch March 22, 2015 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants