-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CImg and WxCam: New Packages #3519
Conversation
Well, sorry my complete lack of understanding on Git... I think the cleaner way to do it was just to create a new branch for CImg, but when I do it, a branch hides the files contained in the other. So, I decided to build both on the same branch. It is not so bat at all - CImg is very simple indeed, just a huge CImg.h file (and some extra documentation); and WxCam is not so hard to understand too... |
meta = { | ||
description = "A small, open source, C++ toolkit for image processing"; | ||
homepage = http://cimg.sourceforge.net/; | ||
license = cecill-c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the license is not inside `with stdenv.lib`` here, am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the license is in stdenv.lib! Line 80 of lib/licenses.nix.
Also, many thanks, I will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- buildInputs = with stdenv.lib;
- [ unzip ];
- builder = ./builder.sh;
- meta = {
- description = "A small, open source, C++ toolkit for image processing";
- homepage = http://cimg.sourceforge.net/;
- license = cecill-c;
Yes, the license is in stdenv.lib! Line 80 of lib/licenses.nix.
But this line seems to be out of scope where stdenv.lib.licenses is
visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always forget the stdenv.lib path :/
In this commit, I'm including two new softwares * CImg: A small, simple image toolkit library * WxCam: a small, simple, wxGTK-based webcam application
install -m 644 CImg.h $out/include/cimg | ||
cp -dr --no-preserve=ownership html/* $out/share/doc/cimg/html/ | ||
cp -dr --no-preserve=ownership examples/* $out/share/cimg/examples/ | ||
cp -dr --no-preserve=ownership plugins/* $out/share/cimg/plugins/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you only need to set dontBuild=true
in the expression and override only installPhase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I like the builder.sh approach when the building is completely ad-hoc. It is considered "old-fashioned" but is more modular...
In this commit, I'm including two new softwares * CImg: A small, simple image toolkit library * WxCam: a small, simple, wxGTK-based webcam application
Merged manually. |
Yes, merged, closing. |
In this commit, I'm including two softwares: