Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default icon location in 'wrapFirefox' #3536

Merged
merged 1 commit into from
Aug 16, 2014

Conversation

jgeerds
Copy link
Member

@jgeerds jgeerds commented Aug 11, 2014

This pull request probably fixes #2897

/nix/store/3r83139gsh0qqifv9x7x1fq7h2maxyhg-firefox-with-plugins-31.0/share/applications/firefox.desktop:

[Desktop Entry]
Type=Application
Exec=firefox %U
Icon=/nix/store/7yrxr3yd4c3vgx48c89xi20hybcmdy6n-firefox-31.0/lib/firefox-31.0/icons/mozicon128.png
[...]

The icon path doesn't exist. Instead, this is the correct path:

/nix/store/7yrxr3yd4c3vgx48c89xi20hybcmdy6n-firefox-31.0/lib/firefox-31.0/browser/icons/mozicon128.png

However, I could not test the new firefoxWrapper package because I can't build the new one. The hash of the build inputs are the same, so calling nix-build $NIXREPO -A firefoxWrapper use the build cache. Is there a way to force a rebuild? or is this a "bug" ?

domenkozar added a commit that referenced this pull request Aug 16, 2014
Fix default icon location in 'wrapFirefox'
@domenkozar domenkozar merged commit 57e17ed into NixOS:master Aug 16, 2014
@jgeerds jgeerds deleted the firefox-wrapper branch October 25, 2014 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firefox - missing icon
2 participants