-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glm: fix gcc 7.3 support #35420
glm: fix gcc 7.3 support #35420
Conversation
BTW, tag |
Yeah, I guess it means alpha. |
Hmm, both of my machines failed
Not sure what is the cause of the failure. |
Too small |
I don't think so.. I have tried to remount |
It might not be using /tmp, for example on NixOS. Set TMPDIR. I would prefer a tagged version. I don't really know anything about this package, I was merely listed as maintainer so I could receive updates when new versions came out upstream from a monitoring tool we had so I can't offer much insight into any specifics. |
After I run |
I ended up adding another version of |
5873185
to
c077094
Compare
Sorry for the mess, in fact we still need to patch We should patch the
So the only way to make all packages depends on |
This will also fix several packages' build
I think this is ready to be merged. |
Motivation for this change
slop
fails to build after switching to gcc 7.3The reason seems to be that
glm
did not correctly support gcc 7.3 . Although this issue have been fixed by upstream in g-truc/glm@dd48b56 , they haven't release any stable version contains the fix.This PR fixes the issue by fetching new version of
platform.h
. (patches
andfetchpatch
cannot be used because that commit have some content which cannot be automatically merged)cc maintainer @Fuuzetsu
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)