Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python fixes #37439

Merged
merged 15 commits into from
Mar 20, 2018
Merged

Python fixes #37439

merged 15 commits into from
Mar 20, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

#36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner March 20, 2018 12:08
@dotlambda
Copy link
Member Author

@FRidh What do you think about removing djblets? I didn't try updating it because it now depends on nodejs. What should we do with reviewboard which depends on djblets?

@dotlambda
Copy link
Member Author

dotlambda commented Mar 20, 2018 •
edited
Loading

It seems like reviewboard version 2.5.1.1, which is in Nixpkgs, was released in 2015. If some maintainer still had an interest in reviewboard, they'd have updated it. So I vote for just removing it. Rbtools should then be removed as well.
Rbtools can still be kept because it seems to be an API wrapper for reviewboard.
/cc rbtools maintainer @domenkozar

@dotlambda dotlambda mentioned this pull request Mar 20, 2018
Closed
8 tasks
@FRidh
Copy link
Member

FRidh commented Mar 20, 2018

It seems like reviewboard version 2.5.1.1, which is in Nixpkgs, was released in 2015. If some maintainer still had an interest in reviewboard, they'd have updated it. So I vote for just removing it.

Go for it, delete both reviewboard and djblets.

Robert Schütz added 13 commits March 20, 2018 17:32
pythonPackages.django_pipeline: 1.5.1 -> 1.6.14
6e78005
pythonPackages.{reviewboard,djblets}: uninit
fbff08f 
Djblets is unmaintained: has not been updated since 2015, but had many releases.
Dependency django_pipeline_1_3 is broken and should anyway be removed from pythonPackages because we want to have a consistent package set.
Because the reviewboard package also hasn't been updated since 2015 and depends on djblets, it is removed as well.
pythonPackages.stem: move expression
061e798
pythonPackages.stem: run unit tests
685dd8d
pythonPackages.zope_copy: 4.0.2 -> 4.1.0
12695be
pythonPackages.deform: move expression
a1b9cc7
pythonPackages.deform: 2.0.a2 -> 2.0.5
86f2136
pythonPackages.klein: move expression
86e007b
pythonPackages.klein: 15.3.1 -> 17.10.0
b34af91
pythonPackages.astropy: disable for python 2
3d989e3
pythonPackages.WSME: move expression
9f54b03
pythonPackages.WSME: 0.8.0 -> 0.9.2
2773b76
pythonPackages.altair: fix build
43d8221
@dotlambda dotlambda merged commit dceb9ee into NixOS:master Mar 20, 2018
@dotlambda dotlambda deleted the python-fixes branch March 20, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotlambda @FRidh @GrahamcOfBorg