home-assistant: make hass cloud integration work #38653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: python
2.status: merge conflict
dotlambda
requested changes
Apr 9, 2018
pkgs/top-level/python-packages.nix
Outdated
| @@ -317,6 +317,14 @@ in { | |||
|
|
|||
| pycryptodome = callPackage ../development/python-modules/pycryptodome { }; | |||
|
|
|||
| pycryptodome_3_3 = self.pycryptodome.overridePythonAttrs (oldAttrs: rec { | |||
There was a problem hiding this comment.
There is a policy of having only a single version of each package in pythonPackages
| sha256 = "0vl22411k394biizkjqg1ydclbf6fw5hxixzm1g7jlpzx4z6j9lj"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ cryptography ecdsa future pycryptodome_3_3 six ]; |
There was a problem hiding this comment.
You can probably just patch requirements.txt in postPatch.
| sha256 = "0gw3crg64p1zx3k5js0wh0x5bldgs7viy4g8hld9xbka8q0374hi"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ boto3 envs python-jose-cryptodome requests ]; |
There was a problem hiding this comment.
I opened capless/warrant#98 for using python-jose instead.
There was a problem hiding this comment.
You should be able to use that as a patch, which would get rid of all problems.
There was a problem hiding this comment.
@peterhoeg Did you try applying that patch?
There was a problem hiding this comment.
No, haven't touched this yet. This weekend!
Mic92
reviewed
Apr 9, 2018
| sha256 = "0vl22411k394biizkjqg1ydclbf6fw5hxixzm1g7jlpzx4z6j9lj"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ cryptography ecdsa future pycryptodome_3_3 six ]; |
There was a problem hiding this comment.
Mhm this could be a big hassle if python-jose-cryptodome is mixed with something depending on pycryptodome. Then there are two different versions. which should be avoided.
There was a problem hiding this comment.
Maybe a newer version could be used here? https://github.com/mpdavis/python-jose/blob/master/setup.py#L58
Mic92
reviewed
Apr 9, 2018
| , cryptography, ecdsa, future, pycryptodome_3_3, six }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "python-jose-cryptodome"; |
There was a problem hiding this comment.
Also why did you add another python-jose?
|
Your issues have been addressed @dotlambda and @Mic92 |
GrahamcOfBorg
added
6.topic: stdenv
GrahamcOfBorg
added
8.has: package (new)
|
Success on aarch64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
GrahamcOfBorg
added
6.topic: stdenv
|
No need to use staging anymore, has been merged into master. |
|
@GrahamcOfBorg build python2.pkgs.envs python3.pkgs.envs |
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.envs, python3.pkgs.envs Partial log (click to expand)
|
GrahamcOfBorg
removed
6.topic: stdenv
|
@GrahamcOfBorg build python2.pkgs.warrant python3.pkgs.warrant |
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.warrant, python3.pkgs.warrant Partial log (click to expand)
|
dotlambda
approved these changes
Apr 16, 2018
|
|
||
| propagatedBuildInputs = [ boto3 envs python-jose requests ]; | ||
|
|
||
| # all the checks are failing |
There was a problem hiding this comment.
Their Travis build fails, too. So this is to be expected.
|
Success on aarch64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.envs, python3.pkgs.envs Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.warrant, python3.pkgs.warrant Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'd like to use my "Amazon ~~~spy-device~~~ Echo" to control home assistant.
I haven't actually tried to use it to control HA yet but at least it's connecting.
Should I separate out the pycryptodome override into its own file?
Cc: @dotlambda @FRidh
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)