-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashing: init at 2018-02-15 #38813
dashing: init at 2018-02-15 #38813
Conversation
@GrahamcOfBorg build dashing |
Success on aarch64-linux (full log) Attempted: dashing Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: dashing Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: dashing Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: dashing Partial log (click to expand)
|
pkgs/tools/misc/dashing/default.nix
Outdated
|
||
goDeps = ./deps.nix; | ||
|
||
# TODO: add metadata https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add at least basic metadata! :)
Success on x86_64-linux (full log) Attempted: dashing Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: dashing Partial log (click to expand)
|
5da26d3
to
792fe5c
Compare
Added metadata. I think this is MIT license, I'm not 100% sure though. Also: I am not the maintainer for reasons I expressed in #38504 |
For the record: Now I need to package |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: dashing Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: dashing Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: dashing Partial log (click to expand)
|
@dtzWill Anything left to do? |
pkgs/tools/misc/dashing/default.nix
Outdated
goDeps = ./deps.nix; | ||
|
||
# TODO: add metadata https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes | ||
meta = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, change to meta = with stdenv.lib; {
so we can get rid of the stdenv.lib
bits below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
792fe5c
to
3fc755b
Compare
3fc755b
to
0f32914
Compare
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: dashing Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: dashing Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: dashing Partial log (click to expand)
|
Thanks @matthiasbeyer - now the next step is to create docsets for the nix ecosystem! ;-) |
Motivation for this change
I want to use this. I'd love if this gets into 18.03 even, but if not I don't care (I can backport locally).
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)