-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mediathekview: 9 -> 13.2.1 #38964
mediathekview: 9 -> 13.2.1 #38964
Conversation
c8e654f
to
b10d52d
Compare
I get now:
|
Ah also mentioned in the description. |
Btw, the old version isn't working anymore. If you want to use Mediatheview in the meantime you can use it with the Oracle JRE, as it has JavaFX bundled. That might be a solution for the package as well until openjfx is working. |
b10d52d
to
c8ca41b
Compare
I've updated the PR so it now uses the OracleJRE. As the package isn't usable at the moment otherwise, I think this is the best way to go forward until OpenJFX is supported. |
c8ca41b
to
93393f3
Compare
@Mic92 Could you have a look again please? |
93393f3
to
57fcd6c
Compare
There is still an evaluation error for darwin, which I try to fix in: |
57fcd6c
to
37205e2
Compare
@Mic92 I've cleaned up a few things (derivation inputs, removed java flags) and removed the obsolete Edit: And moved the |
homepage = https://mediathekview.de/; | ||
license = licenses.gpl3; | ||
maintainers = with maintainers; [ chaoflow moredread ]; | ||
platforms = platforms.all; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limiting factor here would be probably our bash wrapper that does not run as it is on windows. But I think it should work apart from that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it from one of the old zdfmediathk
package. Should I change it or leave it as is?
@GrahamcOfBorg build mediathekview |
Use OracleJRE for now, as OpenJFX isn't packaged yet for OpenJDK.
The package `mediathekview` is the current alternative.
37205e2
to
c18c25f
Compare
Motivation for this change
First,
zdfmediathk
seems to be a duplicate ofmediathekview
, as the upstream project is https://mediathekview.de now. (Not yet removed in this PR).I got the recent version almost working, but the dependency
OpenJFX
isn't available in nix yet. See issue #16727 for that.I used the
zdfmediathk
expression as the base for the update as it seemed more complete, but the package namemediathekview
matches how upstream calls the package.@chaoflow @flosse: Are you still interested in maintaining MediathekView? Have you tried updating the package recently?
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)