Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: use jemalloc 4.5.0 #38995

Merged
merged 3 commits into from
Apr 16, 2018
Merged

rocksdb: use jemalloc 4.5.0 #38995

merged 3 commits into from
Apr 16, 2018

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

Using rocksdb with jemalloc 5 is giving us some problems.
We currently tell everyone to override it, but it's not ideal. This shouldn't be needed once 5.1 comes out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

@GrahamcOfBorg build jemalloc450 jemalloc rocksdb

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: jemalloc450, jemalloc

The following builds were skipped because they don't evaluate on aarch64-linux: rocksdb

Partial log (click to expand)

unpacking source archive /nix/store/b9dfy92gxqfraspgqy6rg878gxsaix9c-jemalloc-4.5.0.tar.bz2
source root is jemalloc-4.5.0
setting SOURCE_DATE_EPOCH to timestamp 1488337890 of file jemalloc-4.5.0/doc/jemalloc.3
patching sources
applying patch /nix/store/b6f91c62msrmhq6y8pcpbvk1blx8y0gi-1035.patch
patching file include/jemalloc/internal/rtree.h
Hunk #1 FAILED at 178.
1 out of 1 hunk FAILED -- saving rejects to file include/jemalloc/internal/rtree.h.rej
builder for '/nix/store/87jsds5r4afi808p46sixi2c84j6593d-jemalloc-4.5.0.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/87jsds5r4afi808p46sixi2c84j6593d-jemalloc-4.5.0.drv' failed

@lukateras
Copy link
Member

lukateras commented Apr 16, 2018 •
edited
Loading

@yorickvP Could it be that https://patch-diff.githubusercontent.com/raw/jemalloc/jemalloc/pull/1035.patch doesn't apply on top of jemalloc 4.5.0?

unpacking source archive /nix/store/b9dfy92gxqfraspgqy6rg878gxsaix9c-jemalloc-4.5.0.tar.bz2
source root is jemalloc-4.5.0
setting SOURCE_DATE_EPOCH to timestamp 1488337890 of file jemalloc-4.5.0/doc/jemalloc.3
patching sources
applying patch /nix/store/b6f91c62msrmhq6y8pcpbvk1blx8y0gi-1035.patch
patching file include/jemalloc/internal/rtree.h
Hunk #1 FAILED at 178.
1 out of 1 hunk FAILED -- saving rejects to file include/jemalloc/internal/rtree.h.rej
builder for '/nix/store/87jsds5r4afi808p46sixi2c84j6593d-jemalloc-4.5.0.drv' failed with exit code 1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: jemalloc450, jemalloc, rocksdb

Partial log (click to expand)

/nix/store/v60zzcyql2kkcnbkqjxp5w745ky7x9xp-rocksdb-5.10.3/lib/librocksdb.5.10.3.dylib: fixing dylib
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gg4pnardgffmsa4dc1nbbddda40wmcd0-rocksdb-5.10.3-static/lib
patching script interpreter paths in /nix/store/gg4pnardgffmsa4dc1nbbddda40wmcd0-rocksdb-5.10.3-static
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kaq94dp5f4hvkvbg27vybrkvnmxspczg-rocksdb-5.10.3-bin/bin
patching script interpreter paths in /nix/store/kaq94dp5f4hvkvbg27vybrkvnmxspczg-rocksdb-5.10.3-bin
/nix/store/2i7fmykj7x39qfmfvfzc7h1p1wkw1va7-jemalloc-4.5.0
/nix/store/dd4ck2szibc8pawm8gw19hld96y7hv2f-jemalloc-5.0.1
/nix/store/xmn9zdlcylk1mcm6vks5kn0bsylaah4k-rocksdb-5.10.3-dev

@lukateras
Copy link
Member

Certainly looks like it: patch is only applied on aarch64.

@lukateras
Copy link
Member

@GrahamcOfBorg build jemalloc450 jemalloc

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: jemalloc450, jemalloc

Partial log (click to expand)

/nix/store/5lkrw9dnsgy62qm1ampvww1c5n1pdm4b-coreutils-8.29/bin/install -c -m 644 doc/jemalloc.html /nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/share/doc/jemalloc
/nix/store/5lkrw9dnsgy62qm1ampvww1c5n1pdm4b-coreutils-8.29/bin/install -c -d /nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/share/man/man3
/nix/store/5lkrw9dnsgy62qm1ampvww1c5n1pdm4b-coreutils-8.29/bin/install -c -m 644 doc/jemalloc.3 /nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/share/man/man3
post-installation fixup
gzipping man pages under /nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/lib  /nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/bin
patching script interpreter paths in /nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0
/nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/bin/jemalloc-config: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/lgc5kk6257vp2plrl04vf5d5gz6wqwpl-jemalloc-4.5.0/bin/jemalloc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jemalloc450, jemalloc

Partial log (click to expand)

shrinking /nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0/lib/libjemalloc.so.2
gzipping man pages under /nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0/lib  /nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0/bin
patching script interpreter paths in /nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0
/nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0/bin/jemalloc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0/bin/jemalloc-config: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0...
/nix/store/x2z8lpsz1s8vnn3cavyk1k98pp0xrf25-jemalloc-4.5.0
/nix/store/w0cz4w40nvbqa1ga8am3wgx0v734bv9n-jemalloc-5.0.1

@lukateras lukateras merged commit d17d4b7 into NixOS:master Apr 16, 2018
@yorickvP yorickvP deleted the rocksdb-jemalloc branch April 16, 2018 16:23
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jemalloc450, jemalloc, rocksdb

Partial log (click to expand)

these paths will be fetched (0.27 MiB download, 2.29 MiB unpacked):
  /nix/store/wiimy8pkpf9v57gvqaa1npqk17965pym-jemalloc-5.0.1
copying path '/nix/store/wiimy8pkpf9v57gvqaa1npqk17965pym-jemalloc-5.0.1' from 'https://cache.nixos.org'...
/nix/store/2jzs75jhq8590i1vwc89dks1hzfpac7i-jemalloc-4.5.0
/nix/store/wiimy8pkpf9v57gvqaa1npqk17965pym-jemalloc-5.0.1
/nix/store/rvzj3hx27zvg6lv12l3d2wrnjsibdw9g-rocksdb-5.10.3-dev

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jemalloc450, jemalloc

Partial log (click to expand)

these paths will be fetched (0.50 MiB download, 4.10 MiB unpacked):
  /nix/store/2jzs75jhq8590i1vwc89dks1hzfpac7i-jemalloc-4.5.0
  /nix/store/wiimy8pkpf9v57gvqaa1npqk17965pym-jemalloc-5.0.1
copying path '/nix/store/2jzs75jhq8590i1vwc89dks1hzfpac7i-jemalloc-4.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/wiimy8pkpf9v57gvqaa1npqk17965pym-jemalloc-5.0.1' from 'https://cache.nixos.org'...
/nix/store/2jzs75jhq8590i1vwc89dks1hzfpac7i-jemalloc-4.5.0
/nix/store/wiimy8pkpf9v57gvqaa1npqk17965pym-jemalloc-5.0.1

@prusnak prusnak mentioned this pull request Dec 30, 2021
Merged
13 tasks
prusnak added a commit to prusnak/nixpkgs that referenced this pull request Dec 30, 2021
@prusnak
jemalloc450: drop package
abc618a 
The package was introduced in NixOS#38995
to fix rocksdb, but rocksdb is not using jemalloc450 anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yorickvP @lukateras @GrahamcOfBorg