-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gflags: alias to google-gflags #39075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both packages referred to the same repo (`gflags/gflags` at GitHub), both packages used almost the same version (2.2.1 and 2.2.0). Therefore I think that it's just fair to drop one of the packages to avoid duplication and reduce the maintenance overload. I decided to drop `gflags` originally packaged by @shlevy as it didn't contain testing support as `google-gflags` does. The package set refers from `gflags` to `google-gflags`, so both package names remain (to avoid any confusions), however the `gflags` expression is removed.
currently running |
@GrahamcOfBorg build gflags |
Success on x86_64-darwin (full log) Attempted: gflags Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: gflags Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: gflags Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: gflags Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: gflags Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Both packages referred to the same repo (
gflags/gflags
at GitHub),both packages used almost the same version (2.2.1 and 2.2.0). Therefore
I think that it's just fair to drop one of the packages to avoid
duplication and reduce the maintenance overload.
I decided to drop
gflags
originally packaged by @shlevy as it didn'tcontain testing support as
google-gflags
does. The package set refersfrom
gflags
togoogle-gflags
, so both package names remain (to avoidany confusions), however the
gflags
expression is removed.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)