Reapply the multi-ip code #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….ipv6"" This reverts commit ea89106.
|
Nice. Ipv4 part tested and proven to work with my network setup. No errors, neither with the old syntax [1] nor with the new syntax [2]. [1] https://gist.github.com/robberer/5cf11e13b798cdf6c318 Can't say anything about ipv6. |
|
It's been working fine in my multi-ipv6 and single ipv6 deployments. The only reason it was reverted is because I quickly hacked together compatibility support and made a typo. |
| @@ -20,10 +40,36 @@ let | |||
| description = "Name of the interface."; | |||
| }; | |||
|
|
|||
| ip4 = mkOption { | |||
There was a problem hiding this comment.
This should be ipv4 and ipv6, respectively, for consistency with other NixOS options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset reapplies the multi-ip changes with a fix that corrects a bug in translating old syntax to new syntax.